Re: [PATCH v3] target/iblock: split T10 PI SGL across command bios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on target/for-next]
[also build test WARNING on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Greg-Edwards/target-iblock-split-T10-PI-SGL-across-command-bios/20180831-204618
base:   https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
config: i386-randconfig-h1-09010405 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers//target/target_core_iblock.c: In function 'iblock_alloc_bip':
   drivers//target/target_core_iblock.c:663:2: error: implicit declaration of function 'bio_integrity_bytes' [-Werror=implicit-function-declaration]
     bip->bip_iter.bi_size = bio_integrity_bytes(bi, bio_sectors(bio));
     ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:14,
                    from include/linux/list.h:9,
                    from include/linux/timer.h:5,
                    from drivers//target/target_core_iblock.c:29:
>> include/linux/dynamic_debug.h:75:16: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' [-Wformat=]
     static struct _ddebug  __aligned(8)   \
                   ^
   include/linux/dynamic_debug.h:111:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
     DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, 0, 0)
     ^
   include/linux/dynamic_debug.h:125:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/printk.h:333:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers//target/target_core_iblock.c:681:3: note: in expansion of macro 'pr_debug'
      pr_debug("Added bio integrity page: %p length: %lu offset: %lu\n",
      ^
   cc1: some warnings being treated as errors
--
   drivers/target/target_core_iblock.c: In function 'iblock_alloc_bip':
   drivers/target/target_core_iblock.c:663:2: error: implicit declaration of function 'bio_integrity_bytes' [-Werror=implicit-function-declaration]
     bip->bip_iter.bi_size = bio_integrity_bytes(bi, bio_sectors(bio));
     ^
   In file included from include/linux/printk.h:329:0,
                    from include/linux/kernel.h:14,
                    from include/linux/list.h:9,
                    from include/linux/timer.h:5,
                    from drivers/target/target_core_iblock.c:29:
>> include/linux/dynamic_debug.h:75:16: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' [-Wformat=]
     static struct _ddebug  __aligned(8)   \
                   ^
   include/linux/dynamic_debug.h:111:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
     DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, 0, 0)
     ^
   include/linux/dynamic_debug.h:125:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA'
     DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);  \
     ^
   include/linux/printk.h:333:2: note: in expansion of macro 'dynamic_pr_debug'
     dynamic_pr_debug(fmt, ##__VA_ARGS__)
     ^
   drivers/target/target_core_iblock.c:681:3: note: in expansion of macro 'pr_debug'
      pr_debug("Added bio integrity page: %p length: %lu offset: %lu\n",
      ^
   cc1: some warnings being treated as errors

vim +75 include/linux/dynamic_debug.h

ffa10cb4 Jason Baron 2011-08-11  68  
b9075fa9 Joe Perches 2011-10-31  69  extern __printf(3, 4)
906d2015 Joe Perches 2014-09-24  70  void __dynamic_netdev_dbg(struct _ddebug *descriptor,
ffa10cb4 Jason Baron 2011-08-11  71  			  const struct net_device *dev,
b9075fa9 Joe Perches 2011-10-31  72  			  const char *fmt, ...);
ffa10cb4 Jason Baron 2011-08-11  73  
9049fc74 Jason Baron 2016-08-03  74  #define DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, key, init)	\
c0d2af63 Joe Perches 2012-10-18 @75  	static struct _ddebug  __aligned(8)			\
07613b0b Jason Baron 2011-10-04  76  	__attribute__((section("__verbose"))) name = {		\
07613b0b Jason Baron 2011-10-04  77  		.modname = KBUILD_MODNAME,			\
07613b0b Jason Baron 2011-10-04  78  		.function = __func__,				\
07613b0b Jason Baron 2011-10-04  79  		.filename = __FILE__,				\
07613b0b Jason Baron 2011-10-04  80  		.format = (fmt),				\
07613b0b Jason Baron 2011-10-04  81  		.lineno = __LINE__,				\
07613b0b Jason Baron 2011-10-04  82  		.flags = _DPRINTK_FLAGS_DEFAULT,		\
9049fc74 Jason Baron 2016-08-03  83  		dd_key_init(key, init)				\
07613b0b Jason Baron 2011-10-04  84  	}
07613b0b Jason Baron 2011-10-04  85  

:::::: The code at line 75 was first introduced by commit
:::::: c0d2af637863940b1a4fb208224ca7acb905c39f dynamic_debug: Remove unnecessary __used

:::::: TO: Joe Perches <joe@xxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux