ACK - Thank you for fix. > -----Original Message----- > From: akpm@xxxxxxxx [mailto:akpm@xxxxxxxx] > Sent: Monday, September 25, 2006 7:59 PM > To: James.Bottomley@xxxxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; > ebiederm@xxxxxxxxxxxx; Kolli, Neela; Ju, Seokmann > Subject: [patch 15/28] megaraid: Use the proper type to hold > the irq number. > > From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> > > When testing on a Unisys machine it was discovered that the > megaraid driver > would not initialize as it was requesting irq 162 instead of > irq 1442 it > was assigned. The problem was the irq number had been > truncated by being > stored in an unsigned char. > > This patches fixes that problem and the driver now appears to work. > > The ioctl interface appears fundamentally broken as it exports the irq > number to user space in an unsigned char. > > Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> > Cc: Neela Syam Kolli<Neela.Kolli@xxxxxxxxxxx> > Cc: "Ju, Seokmann" <Seokmann.Ju@xxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxx> > --- > > drivers/scsi/megaraid/mega_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN > drivers/scsi/megaraid/mega_common.h~megaraid-use-the-proper-ty > pe-to-hold-the-irq-number drivers/scsi/megaraid/mega_common.h > --- > a/drivers/scsi/megaraid/mega_common.h~megaraid-use-the-proper- > type-to-hold-the-irq-number > +++ a/drivers/scsi/megaraid/mega_common.h > @@ -175,7 +175,7 @@ typedef struct { > uint8_t max_lun; > > uint32_t unique_id; > - uint8_t irq; > + int irq; > uint8_t ito; > caddr_t ibuf; > dma_addr_t ibuf_dma_h; > _ > - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
