On Fri, Aug 24, 2018 at 01:37:12PM -0500, Mike Christie wrote: > Also, let idr_alloc return value through instead of replacing it with -ENOMEM, > as it is already a negative value and caller checks sign, not exact value. I bet it's less code to just return -ENOMEM in all situations instead of making the compiler remember the return value from idr_alloc(). The patch becomes smaller, at least ;-)