On Sun, 2018-08-05 at 14:39 +-0300, Avri Altman wrote: +AD4- A +IBw-ufs-port+IB0- is purely a software object. Evidently, the function +AD4- template takes no port as an argument, as the driver has no concept +AD4- of +ACI-port+ACI-. We only need it as a hanging point in the bsg device tree, +AD4- so maybe a more appropriate term would be: +ACI-ufs-bsg-dev-node+ACI-. +AD4- +AD4- The ufs-port has a pretty lean structure. This is because we are +AD4- using upiu transactions that contains the outmost detailed info, +AD4- so we don't really need complex constructs to support it. +AD4- +AD4- The transport will keep track of its ufs-ports via its scsi host. Since no port concept has been defined in the UFS standard, can the port concept be left out? Have you considered to attach the bsg queue directly to the UFS SCSI host? There are two struct device instances in each Scsi+AF8-Host structure, namely shost+AF8-gendev and shost+AF8-dev. I think the former corresponds to /sys/bus/scsi/devices/host+ADw-n+AD4- and the latter corresponds to /sys/class/scsi+AF8-host/host+ADw-n+AD4-. The bsg queue probably can be attached to the latter. Several SCSI drivers already add additional sysfs attributes to the /sys/class/scsi+AF8-host/host+ADw-n+AD4-. Thanks, Bart.
