Hello Quinn Tran,
This is a semi-automatic email about new static checker warnings.
The patch 8777e4314d39: "scsi: qla2xxx: Migrate NVME N2N handling
into state machine" from Aug 2, 2018, leads to the following Smatch
complaint:
drivers/scsi/qla2xxx/qla_iocb.c:2647 qla2x00_els_dcmd2_sp_done()
error: we previously assumed 'e' could be null (see line 2631)
drivers/scsi/qla2xxx/qla_iocb.c
2630 e = qla2x00_alloc_work(vha, QLA_EVT_UNMAP);
2631 if (!e) {
^^^^^^^^^
New check for NULL
2632 struct srb_iocb *elsio = &sp->u.iocb_cmd;
2633
2634 if (elsio->u.els_plogi.els_plogi_pyld)
2635 dma_free_coherent(&sp->vha->hw->pdev->dev,
2636 elsio->u.els_plogi.tx_size,
2637 elsio->u.els_plogi.els_plogi_pyld,
2638 elsio->u.els_plogi.els_plogi_pyld_dma);
2639
2640 if (elsio->u.els_plogi.els_resp_pyld)
2641 dma_free_coherent(&sp->vha->hw->pdev->dev,
2642 elsio->u.els_plogi.rx_size,
2643 elsio->u.els_plogi.els_resp_pyld,
2644 elsio->u.els_plogi.els_resp_pyld_dma);
2645 sp->free(sp);
2646 }
2647 e->u.iosb.sp = sp;
^^^^^^^^^^^^
Dereference without checking
2648 qla2x00_post_work(vha, e);
2649 }
regards,
dan carpenter
