Re: [PATCH v2] mpt3sas: correct reset of smid while clearing scsi tracker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-08-03 at 18:55 +-0300, Andy Shevchenko wrote:
+AD4- On Fri, Aug 3, 2018 at 5:06 PM, Bart Van Assche +ADw-Bart.VanAssche+AEA-wdc.com+AD4- wrote:
+AD4- +AD4- On Fri, 2018-08-03 at 06:31 -0400, Sreekanth Reddy wrote:
+AD4- +AD4- +AD4- +-     /+ACo- Added memory barrier to make sure that correct chain tracker
+AD4- +AD4- +AD4- +-      +ACo- is retrieved before incrementing the smid pool's chain+AF8-offset
+AD4- +AD4- +AD4- +-      +ACo- value in chain lookup table.
+AD4- +AD4- +AD4- +-      +ACo-/
+AD4- +AD4- 
+AD4- +AD4- Please verify your patch with checkpatch and use the proper kernel comment style.
+AD4- 
+AD4- This kind of style is what net subsystem is using. Last time I heard
+AD4- about this was that checkpatch doesn't distinguish subsystem and thus
+AD4- allows this kind of style.

Since consistency is appreciated in Linux kernel code and since most other
comments in SCSI code start with +ACI-/+ACoAIg- on a line by itself I think that's the
preferred style for SCSI code.

Thanks,

Bart.





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux