On Mon, Sep 25, 2006 at 10:16:34AM -0700, Luben Tuikov wrote: > --- Douglas Gilbert <dougg@xxxxxxxxxx> wrote: > > Al Viro wrote: > > > To whoever had written that code: > > > > > > a) priority of >> is higher than that of & > > > b) priority of typecast is higher than that of any binary operator > > > c) learn the fscking C > [...] > > BTW Luben was pointing out that the call you patched > > and the following call can be combined into a less > > trouble prone asd_write_reg_dword() call. > > More than that -- I looked at the history of that > file/line and the code as I had written it _never_ had > that broken cast and shift mess. Far more interesting question: where does the hardware expect to see the upper 16 bits of that 32bit value? Which one it is - LmSEQ_INTEN_SAVE(lseq) ori LmSEQ_INTEN_SAVE(lseq) + 2? - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
