Thanks, Avri +AD4- -----Original Message----- +AD4- From: Bart Van Assche +AD4- Sent: Wednesday, August 01, 2018 6:36 PM +AD4- To: hch+AEA-lst.de+ADs- Avri Altman +ADs- linux-scsi+AEA-vger.kernel.org+ADs- +AD4- jthumshirn+AEA-suse.de+ADs- hare+AEA-suse.com+ADs- martin.petersen+AEA-oracle.com+ADs- +AD4- jejb+AEA-linux.vnet.ibm.com +AD4- Cc: Vinayak Holikatti +ADs- Avi Shchislowski +ADs- Alex Lemberg +ADs- Stanislav Nijnikov +ADs- +AD4- subhashj+AEA-codeaurora.org +AD4- Subject: Re: +AFs-PATCH 4/6+AF0- scsi: ufs: Add API to execute raw upiu commands +AD4- +AD4- On Wed, 2018-08-01 at 11:04 +-0300, Avri Altman wrote: +AD4- +AD4- +-/+ACoAKg- +AD4- +AD4- +- +ACo- ufshcd+AF8-exec+AF8-raw+AF8-upiu+AF8-cmd - API function for sending raw upiu +AD4- commands +AD4- +AD4- +- +ACo- +AEA-hba: per-adapter instance +AD4- +AD4- +- +ACo- +AEA-req+AF8-upiu: upiu request - 8 dwards +AD4- +AD4- +- +ACo- +AEA-rsp+AF8-upiu: upiu reply - 8 dwards +AD4- +AD4- +- +ACo- +AEA-msgcode: message code, one of UPIU Transaction Codes +AD4- Initiator to Target +AD4- +AD4- +- +ACo- +AEA-desc+AF8-buff: pointer to descriptor buffer, NULL if NA +AD4- +AD4- +- +ACo- +AEA-buff+AF8-len: descriptor size, 0 if NA +AD4- +AD4- +- +ACo- +AEA-rw: either READ or WRITE +AD4- +AD4- +- +ACo- +AD4- +AD4- +- +ACo- Supports UTP Transfer requests (nop and query), and UTP Task +AD4- +AD4- +- +ACo- Management requests. +AD4- +AD4- +- +ACo- It is up to the caller to fill the upiu conent properly, as it will +AD4- +AD4- +- +ACo- be copied without any further input validations. +AD4- +AD4- +- +ACo-/ +AD4- +AD4- +-int ufshcd+AF8-exec+AF8-raw+AF8-upiu+AF8-cmd(struct ufs+AF8-hba +ACo-hba, +AD4- +AD4- +- +AF8AXw-be32 +ACo-req+AF8-upiu, +AF8AXw-be32 +ACo-rsp+AF8-upiu, +AD4- +AD4- +- int msgcode, +AD4- +AD4- +- u8 +ACo-desc+AF8-buff, int +ACo-buff+AF8-len, int rw) +AD4- +AD4- +-+AHs- +AD4- +AD4- Again, what are +ACI-dwards+ACI-? +AD4- +AD4- Documenting the size of a data structure in a function header is very weird. +AD4- Please change the data type of req+AF8-upiu and rsp+AF8-upio into a pointer to a +AD4- structure of the proper size. Ok. +AD4- +AD4- Thanks, +AD4- +AD4- Bart. +AD4-
