On 2018/8/1 23:30, Andy Shevchenko wrote: > On Wed, Aug 1, 2018 at 4:26 PM, zhong jiang <zhongjiang@xxxxxxxxxx> wrote: >> The vzalloc is better than vmalloc+memset, so replace them to make >> the code concise. >> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE)); >> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * PAGE_SIZE)); > At the same time you may get rid of unnecessary parens. > Thanks , I will repost with the change. Thanks zhong jiang