On Sun, Jul 15, 2018 at 06:16:19PM -0500, Mike Christie wrote: > When __transport_register_session is called from > transport_register_session irqs will already have been disabled, > so we do not want the unlock irq call to enable them until > the higher level has done the final > spin_unlock_irqrestore/spin_unlock_irq. if you use up your line length this could be: so we do not want the unlock irq call to enable them until the higher level has done the final spin_unlock_irqrestore/spin_unlock_irq. > > This has __transport_register_session use the save/restore > call. Can be condensed as well. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>