On Tue, Jul 10, 2018 at 10:36 AM Jann Horn <jannh@xxxxxxxxxx> wrote:
>
> AFAICS it does mean that if two processes use /dev/sg* - the first one
> in a way that passes sg_check_file_access(), the second one in a way
> that gets blocked for whatever reason -, the pr_err_once() will fire
> for the process that's working and not fire for the one that got
> blocked. But if nobody should be using that interface anyway, I guess
> that's not a practical concern.
Right. I don't expect it to trigger at all, and the "working" program
should be fixed too, because I want for us to be able to just remove
that idiotic direct access thing.
> Also, the device is called /dev/sg%d with %d being sdp->index.
I guess I could make it at least say that, although it's not like "one
of them would be ok, but /dev/sd3 is right out".
Linus
