On Thu, Jul 05, 2018 at 05:00:10PM +0000, Bart Van Assche wrote: > On Thu, 2018-07-05 at 13:01 +0200, Johannes Thumshirn wrote: > > - cmnd->result = ScsiResult(DID_OK, SCSI_STATUS_GOOD); > > + cmnd->result = DID_OK << 16 | SCSI_STATUS_GOOD; > > Please consider to remove the SCSI_STATUS_GOOD constant since it is > non-standard and since it used by the bfa driver only. Additionally, since > SCSI_STATUS_GOOD == 0, please leave out "| SCSI_STATUS_GOOD". Can we agree on using SAM_STAT_GOOD here? I really don't want to leave out the trailing "| 0" parts in this stage of the refactoring yet. I'm still undecided if I don't want a set_scsi_cmnd_status(cmnd, foo, bar, baz, frob); function in an intermediate step. -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
