On Mon, Jul 2, 2018 at 8:54 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Mon, Jul 02, 2018 at 01:06:42PM +0800, Ming Lei wrote: >> With the introduced module parameter of 'use_blk_mq', it is easy >> to switch between 'blk_mq' and 'non_blk_mq' by reloading scsi_debug >> module, so that we can test scsi_mq/blk_mq related regressions easily. > > No. We should not make a per driver choice. Could you share us why we can't? BTW, this patch can make scsi_mq/blk_mq regression tests to be implemented very easily, such as, run one test in non-mq mode, and run it in mq mode, then compare the two. Thanks, Ming Lei
