-----Original Message----- From: Kyuho Choi [mailto:chlrbgh0@xxxxxxxxx] Sent: Monday, June 18, 2018 6:50 AM To: Sayali Lokhande <sayalil@xxxxxxxxxxxxxx> Cc: subhashj@xxxxxxxxxxxxxx; cang@xxxxxxxxxxxxxx; vivek.gautam@xxxxxxxxxxxxxx; rnayak@xxxxxxxxxxxxxx; vinholikatti@xxxxxxxxx; jejb@xxxxxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; asutoshd@xxxxxxxxxxxxxx; evgreen@xxxxxxxxxxxx; riteshh@xxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx Subject: Re: [PATCH V3 0/3] Add ufs provisioning support in driver Hi, On 6/14/18, Sayali Lokhande <sayalil@xxxxxxxxxxxxxx> wrote: > This change adds a new API ufshcd_do_config_device() to write > configuration descriptor with the provisioning data. > Configfs support is added in driver to trigger ufs provisioning at > runtime. Provisioning data is parsed from vendor specific provisioning > file. This parsed data is passed as a buffer via configfs to provision > ufs device. AFAIK, ufd device's every data are will be removed after provisioning. How this working on mobile platform?. Could you share the provisioning and downloading sequence what you expecting?. [Sayali] : Yes, after provisioning, device data will be all removed. Runtime UFS provisioning can be primarily useful during the factory or assembly line. Some devices may be required to be configured multiple times during system setup or system development as long as bConfigDescrLock is unset. Once re-provisioned, some custom/advanced tool will be required to update partitioning details inside updated provisioning scheme. I am mostly using it in very initial stage (unprovisioned device). Provisioning sequence includes: 1. Parsing provisioning data from vendor specific xml file using python script. 2. echo <provisioning_buffer_parsed_above> to configfs node. 3. Reboot device to check updated provisioning. > > Changes since V2: > Added configfs support for ufs provisioning and removed sysfs > support. > > Changes since V1: > Added device tree entry to parse reference clock frequency > instead of hardcoding 19.2 MHz, as it can vary for different > vendors. Also removed setting ref_clk again during runtime > provisioning as it will be already set during probe. > Used get_unaligned_be*/put_unaligned_be* where applicable. > > Changes since RFC: > Added check to avoid ufs runtime provisioning if > Configuration decriptor lock attribute is set to one. > Instead of parsing ref_clk frequency via device tree, used > correct enum ref_clk_freq value(19.2 Mhz for proviosioning). > Added config_descriptor sysfs entry to provision ufs and also > updated documentation for its correct usage. > Added more protection against bad data handling in sysfs code. > > > Sayali Lokhande (2): > scsi: ufs: Add ufs provisioning support > scsi: ufs: Add configfs support for ufs provisioning > > Subhash Jadavani (1): > scsi: ufs: set the device reference clock setting > > Documentation/ABI/testing/configfs-driver-ufs | 14 ++ > .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 + > drivers/scsi/ufs/Makefile | 1 + > drivers/scsi/ufs/ufs-configfs.c | 191 +++++++++++++++++ > drivers/scsi/ufs/ufs.h | 39 ++++ > drivers/scsi/ufs/ufshcd-pltfrm.c | 24 +++ > drivers/scsi/ufs/ufshcd.c | 234 > +++++++++++++++++++++ > drivers/scsi/ufs/ufshcd.h | 10 + > 8 files changed, 520 insertions(+) > create mode 100644 Documentation/ABI/testing/configfs-driver-ufs > create mode 100644 drivers/scsi/ufs/ufs-configfs.c > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, a Linux Foundation Collaborative Project > >
