On 06/21/2018 10:52 PM, Mike Christie wrote: > +static int tcmu_set_block_netlink(const char *str, > + const struct kernel_param *kp) > +{ > + int ret; > + u8 val; > + > + ret = kstrtou8(str, 0, &val); > + if (ret < 0) > + return ret; > + > + if (val > 1 || val < 0) { Darn. I meant to send a different version of the patch where it did if (val != 1) { since its a unsigned value. I will resend this patch after you guys review it.