Hello Martin, This patch series addresses the complaints reported by multiple static source code analysis tools about the mpt3sas source code. Please consider these patches for kernel v4.19. Thanks, Bart. Changes compared to v1: - Addressed Randy Dunlap's feedback about kernel-doc headers. Bart Van Assche (8): mpt3sas: Fix indentation mpt3sas: Remove set-but-not-used variables mpt3sas: Annotate switch/case fall-through mpt3sas: Introduce struct mpt3sas_nvme_cmd mpt3sas: Fix _transport_smp_handler() error path mpt3sas: Fix a race condition in mpt3sas_base_hard_reset_handler() mpt3sas: Split _base_reset_handler(), mpt3sas_scsih_reset_handler() and mpt3sas_ctl_reset_handler() mpt3sas: Improve kernel-doc headers drivers/scsi/mpt3sas/mpt3sas_base.c | 366 +++++++---------- drivers/scsi/mpt3sas/mpt3sas_base.h | 23 +- drivers/scsi/mpt3sas/mpt3sas_config.c | 74 ++-- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 357 +++++++++------- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 428 +++++++------------- drivers/scsi/mpt3sas/mpt3sas_transport.c | 62 ++- drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c | 18 +- drivers/scsi/mpt3sas/mpt3sas_warpdrive.c | 3 - 8 files changed, 568 insertions(+), 763 deletions(-) -- 2.17.0