On 06/14/2018 09:49 AM, Bart Van Assche wrote: > This patch avoids that warnings about the kernel headers appear when > building with W=1. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx> > Cc: Sathya Prakash <sathya.prakash@xxxxxxxxxxxx> > Cc: Chaitra P B <chaitra.basappa@xxxxxxxxxxxx> > Cc: Suganath Prabu Subramani <suganath-prabu.subramani@xxxxxxxxxxxx> > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 16 +- > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 251 +++++++++++--------- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 36 +-- > drivers/scsi/mpt3sas/mpt3sas_transport.c | 10 +- > drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c | 18 +- > drivers/scsi/mpt3sas/mpt3sas_warpdrive.c | 3 - > 6 files changed, 186 insertions(+), 148 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index 9c233ddc5b2b..67e1b603f287 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -103,7 +103,8 @@ _base_get_ioc_facts(struct MPT3SAS_ADAPTER *ioc); > > /** > * _scsih_set_fwfault_debug - global setting of ioc->fwfault_debug. > - * > + * @val: ? > + * @kp: ? > */ > static int > _scsih_set_fwfault_debug(const char *val, const struct kernel_param *kp) > @@ -197,7 +198,7 @@ _base_clone_to_sys_mem(void __iomem *dst_iomem, void *src, u32 size) > * @smid: system request message index > * @sge_chain_count: Scatter gather chain count. > * > - * @Return: chain address. > + * Returns the chain address. > */ Hi Bart, Documentation/doc-guide/kernel-doc.rst says that Return info "should be" described in a Return: section: <quote> The return value, if any, should be described in a dedicated section named ``Return``. </quote> This applies to many instances in this patch. thanks, -- ~Randy
