On Thu, Jun 14, 2018 at 9:18 AM, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote: > Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock > management duties from lldds") the sas_ata_qc_issue() function unlocks > the ata_port.lock and disables interrupts before doing so. > That lock is always taken with disabled interrupts so at this point, the > interrupts are already disabled. There is no need to disable the > interrupts before the unlock operation because they are already > disabled. > Restoring the interrupt state later does not change anything because > they were disabled and remain disabled. Therefore remove the operations > which do not change the behaviour. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>