On Thu, Jun 14, 2018 at 2:57 PM, Zhouyang Jia <jiazhouyang09@xxxxxxxxx> wrote: > When pci_iomap fails, the lack of error-handling code may > cause unexpected results. What results? How had you tested it? > This patch adds error-handling code after calling pci_iomap. > + if (bfad->pci_bar2_kva == NULL) { > + printk(KERN_ERR "Fail to map bar2\n"); pr_err() ? > + goto out_unmap_bar0; > + } -- With Best Regards, Andy Shevchenko