Re: [PATCH v2 2/3] scsi: check for equality of result byte values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-06-13 at 09:53 +0200, Johannes Thumshirn wrote:
>  		if ((cmd->result == (DID_OK << 16)
> -		     || status_byte(cmd->result) &
> -		     CHECK_CONDITION)) {
> +		     || status_byte(cmd->result) == CHECK_CONDITION)) {

A minor comment: the preferred coding style is to place "||" at the end of the
previous line.

> -		if ((driver_byte(the_result) & DRIVER_SENSE) == 0) {
> +		if (driver_byte(the_result) == DRIVER_SENSE) {

This change looks wrong to me.

Bart.






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux