On Wed, Jun 13, 2018 at 09:53:49AM +0200, Johannes Thumshirn wrote: > Some drivers are ADDing the scsi command's result bytes instead of > ORing them. > > While this can produce correct results it has unexpected side effects. > > Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> > - cmd->result = (DID_OK << 16) + (l & STATUS_MASK); > + cmd->result = DID_OK << 16 | (l & STATUS_MASK); Although I would have keep the braces around the shift operators to stick closer to the original code. But the code should be fine even without them.
