Hi Johannes, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v4.17 next-20180612] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Johannes-Thumshirn/Preparation-patch-set-for-SCSI-results-rework/20180612-221711 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-x010-201823 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from drivers/scsi/sym53c8xx_2/sym_fw.c:40:0: drivers/scsi/sym53c8xx_2/sym_glue.h: In function 'sym_set_cam_result_ok': >> drivers/scsi/sym53c8xx_2/sym_glue.h:259:47: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] cmd->result = DID_OK << 16 | cp->ssss_status & 0x7f; ~~~~~~~~~~~~~~~~^~~~~~ vim +259 drivers/scsi/sym53c8xx_2/sym_glue.h 252 253 /* 254 * Build CAM result for a successful IO and for a failed IO. 255 */ 256 static inline void sym_set_cam_result_ok(struct sym_ccb *cp, struct scsi_cmnd *cmd, int resid) 257 { 258 scsi_set_resid(cmd, resid); > 259 cmd->result = DID_OK << 16 | cp->ssss_status & 0x7f; 260 } 261 void sym_set_cam_result_error(struct sym_hcb *np, struct sym_ccb *cp, int resid); 262 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
