On 2018/5/31 22:09, John Garry wrote:
On 29/05/2018 03:23, Jason Yan wrote:We are using lldd_port_deformed so we'd better check if lldd_port_deformed is NULL. Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx> CC: John Garry <john.garry@xxxxxxxxxx> CC: Johannes Thumshirn <jthumshirn@xxxxxxx> CC: Ewan Milne <emilne@xxxxxxxxxx> CC: Christoph Hellwig <hch@xxxxxx> CC: Tomas Henzl <thenzl@xxxxxxxxxx> CC: Dan Williams <dan.j.williams@xxxxxxxxx> CC: Hannes Reinecke <hare@xxxxxxxx> --- drivers/scsi/libsas/sas_discover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index a0fa7ef3a071..354f6db5bb66 100644 --- a/drivers/scsi/libsas/sas_discover.c +++ b/drivers/scsi/libsas/sas_discover.c @@ -260,7 +260,7 @@ static void sas_suspend_devices(struct work_struct *work) * phy_list is not being mutated */ list_for_each_entry(phy, &port->phy_list, port_phy_el) { - if (si->dft->lldd_port_formed) + if (si->dft->lldd_port_deformed)If you do make this change, then you can remove hisi_sas_port_deformed(), as it is just a stub to avoid a jump to NULL from above.
OK, I will remove it.
si->dft->lldd_port_deformed(phy); phy->suspended = 1; port->suspended = 1;.
