Hi Evan, I have some generic notes: - Why to create new sysfs entries for the configuration descriptor fields if they are just duplication of fields in the device and unit descriptors? And the sysfs representation of the device and unit descriptors is existing already. - It would be nice to have some "packet" mode allowing to gather configuration changes and apply them at once, not one by one. - Why to put documentation update in the separate patches? Regards Stanislav > -----Original Message----- > From: Evan Green <evgreen@xxxxxxxxxxxx> > Sent: Tuesday, May 29, 2018 9:18 PM > To: Vinayak Holikatti <vinholikatti@xxxxxxxxx>; James E.J. Bottomley <jejb@xxxxxxxxxxxxxxxxxx>; Martin K. Petersen > <martin.petersen@xxxxxxxxxx>; Stanislav Nijnikov <Stanislav.Nijnikov@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx > Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx>; Evan Green <evgreen@xxxxxxxxxxxx> > Subject: [PATCH 0/7] Enable UFS provisioning via Linux > > This series enables provisioning UFS devices using the existing sysfs > interface. This functionality is primarily useful along the assembly > line, but might also be useful for end users that receive devices that > aren't locked down. > > Evan Green (7): > scsi: ufs: Add Configuration Descriptor to sysfs > scsi: ufs: Add config descriptor documentation > scsi: ufs: Make sysfs attributes writable > scsi: ufs: sysfs: Document attribute writability > scsi: ufs: Refactor descriptor read for write > scsi: ufs: Enable writing config descriptor > scsi: ufs: Update config descriptor documentation > > Documentation/ABI/testing/sysfs-driver-ufs | 174 ++++++++++++++++++++--- > drivers/scsi/ufs/ufs-sysfs.c | 217 ++++++++++++++++++++++++++--- > drivers/scsi/ufs/ufs.h | 29 ++++ > drivers/scsi/ufs/ufshcd.c | 89 ++++++++---- > drivers/scsi/ufs/ufshcd.h | 16 ++- > 5 files changed, 458 insertions(+), 67 deletions(-) > > -- > 2.13.5
