Re: [PATCH 11/14] block: document the blk_eh_timer_return values

[Hannes Reinecke <hare@xxxxxxx>]

On 05/23/2018 02:19 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>   include/linux/blkdev.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 3d9d4da4dedd..3815d9dcfbe0 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -337,8 +337,8 @@ typedef int (init_rq_fn)(struct request_queue *, struct request *, gfp_t);
>   typedef void (exit_rq_fn)(struct request_queue *, struct request *);
>   
>   enum blk_eh_timer_return {
> -	BLK_EH_DONE,
> -	BLK_EH_RESET_TIMER,
> +	BLK_EH_DONE,		/* drivers has completed the command */
> +	BLK_EH_RESET_TIMER,	/* reset timer and try again */
>   };
>   
>   typedef enum blk_eh_timer_return (rq_timed_out_fn)(struct request *);
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes