On Tue, May 22, 2018 at 11:15:09AM -0700, Kees Cook wrote: > Both SCSI and ATAPI share the sense header. In preparation for using the > struct scsi_sense_hdr more widely, move this into a separate header and > move the helper function to scsi_ioctl.c which is linked with CONFIG_IDE > by way of CONFIG_BLK_SCSI_REQUEST. Please keep the code where it is and just depend on SCSI on the legacy ide driver. No need to do gymnastics just for a legacy case.