[bug report] scsi: qlogicfas: move bus_reset to host_reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ This one is not really your fault but you renamed things so it's
  showing up as a new warning.  - dan ]

Hello Hannes Reinecke,

The patch 4a56c1c166b6: "scsi: qlogicfas: move bus_reset to
host_reset" from Aug 25, 2017, leads to the following static checker
warning:

	drivers/scsi/pcmcia/qlogic_stub.c:267 qlogic_resume()
	error: NULL dereference inside function 'qlogicfas408_host_reset((0))()'

drivers/scsi/pcmcia/qlogic_stub.c
   254  static int qlogic_resume(struct pcmcia_device *link)
   255  {
   256          scsi_info_t *info = link->priv;
   257  
   258          pcmcia_enable_device(link);
   259          if ((info->manf_id == MANFID_MACNICA) ||
   260              (info->manf_id == MANFID_PIONEER) ||
   261              (info->manf_id == 0x0098)) {
   262                  outb(0x80, link->resource[0]->start + 0xd);
   263                  outb(0x24, link->resource[0]->start + 0x9);
   264                  outb(0x04, link->resource[0]->start + 0xd);
   265          }
   266          /* Ugggglllyyyy!!! */
   267          qlogicfas408_host_reset(NULL);
                                        ^^^^
qlogicfas408_host_reset() doesn't take NULL pointers, it's just going to
crash.

   268  
   269          return 0;
   270  }

regards,
dan carpenter



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux