On Thu, Apr 19, 2018 at 09:48:56AM +1000, Finn Thain wrote: > Every hunk except the last one looks to be equivalent. Not sure why > the last one is treated differently. That's a bug I'd say. thanks for catching it. > Also, I think using two assignments instead of one is a step backwards. Is > there a better helper for this? Yes I think a set_scsi_result(cmd, 0, DID_*, 0, 0); should be way to go as Hannes said. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850