Hi Michael, On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz <schmitzmic@xxxxxxxxx> wrote: > On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: >> On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: >>> New combined SCSI driver for all ESP based Zorro SCSI boards for >>> m68k Amiga. >>> + { >>> + .id = ZORRO_PROD_PHASE5_BLIZZARD_1230_II_FASTLANE_Z3_CYBERSCSI_CYBERSTORM060, >> >> In PCI Land we've usually stopped using PCI IDs unless they are used >> in multiple (missing "places"?) > Short of a complete rewrite of the Zorro driver support code to be > closer to what PCI does, I don' see what can be done about the use of > Zorro IDs. I don't think such a rewrite is planned in the near future, > Geert? I think what Christoph means is the use of the define ZORRO_PROD_PHASE5_BLIZZARD_1230_II_FASTLANE_Z3_CYBERSCSI_CYBERSTORM060 versus hardcoded numbers, or ZORRO_ID(PHASE5, 0x0B, 0). We have a long list of ZORRO_PROD_* definitions in include/uapi/linux/zorro_ids.h because of historical reasons. The list isn't really changing (no new IDs in git history) due to almost no new Zorro boards being made, unlike for PCI, where keeping an in-kernel list is a lot of work, and not desirable. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds