Re: [PATCH v3 0/3] Report all request failures again to user space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/04/18 19:49, Martin K. Petersen wrote:
> 
> Bart,
> 
>> A recent change in the SCSI core caused certain request failures no
>> longer to be reported to user space. Damien noticed this by sending a
>> write request that is not aligned to the write pointer to an SMR drive
>> from user space. Such non-aligned write requests are failed by the
>> drive and such failures should be reported to user space. This patch
>> series makes sure that all SCSI request failures are again reported to
>> user space. This patch series also makes the SCSI core recognize
>> status codes like CONDITION MET as not being an error.  Please
>> consider at least the first patch in this series for the rc stage of
>> kernel v4.17.
> 
> Looks good to me.
> 
> Longer term I'd really like to see the command result integer
> host/driver/msg/status stuff cleaned up. It's super arcane and the
> associated naming schemes make it a very error-prone interface.
> 

I did start a series [1] for this but than got distracted by more urgent
things. I can pick it up again I think.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=iscsi_DID_REQUEUE

	Johannes
-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux