Re: [PATCH 1/2] sd_zbc: Avoid errors due to sd_zbc_check_zone_size() execution

To: Damien Le Moal <damien.lemoal@xxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] sd_zbc: Avoid errors due to sd_zbc_check_zone_size() execution
From: Bart Van Assche <bart.vanassche@xxxxxxx>
Date: Wed, 4 Apr 2018 08:08:22 -0700
Cc: Hannes Reinecke <hare@xxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20180404085418.29205-2-damien.lemoal@wdc.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 04/04/18 01:54, Damien Le Moal wrote:

  static int sd_zbc_check_zone_size(struct scsi_disk *sdkp)
  {
+	u64 sdkp_zone_blocks = sdkp->zone_blocks;

Shouldn't this variable be initialized to zero such that zone sizechanges are accepted even if the SAME field in the REPORT ZONES responseis zero?


Thanks,

Bart.

Follow-Ups:
- Re: [PATCH 1/2] sd_zbc: Avoid errors due to sd_zbc_check_zone_size() execution
  - From: Damien Le Moal

References:
- [PATCH 0/2] Fix errors due to revalidation of ZBC disks
  - From: Damien Le Moal
- [PATCH 1/2] sd_zbc: Avoid errors due to sd_zbc_check_zone_size() execution
  - From: Damien Le Moal