RE: [PATCH 07/15] mpt3sas: Added support for SAS Device Discovery Error Event.

[Chaitra Basappa <chaitra.basappa@xxxxxxxxxxxx>]

Bart,
 Agreed.

Thanks,
 Chaitra

-----Original Message-----
From: Bart Van Assche [mailto:Bart.VanAssche@xxxxxxx]
Sent: Friday, March 30, 2018 9:50 PM
To: chaitra.basappa@xxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx
Cc: Sathya.Prakash@xxxxxxxxxxxx; suganath-prabu.subramani@xxxxxxxxxxxx;
sreekanth.reddy@xxxxxxxxxxxx
Subject: Re: [PATCH 07/15] mpt3sas: Added support for SAS Device Discovery
Error Event.

On Fri, 2018-03-30 at 15:07 +0530, Chaitra P B wrote:
> +	switch (event_data->ReasonCode) {
> +
> +	case MPI25_EVENT_SAS_DISC_ERR_SMP_FAILED:
> +		pr_warn(MPT3SAS_FMT "SMP command sent to the expander"
> +			"(handle:0x%04x, sas_address:0x%016llx,"
> +			"physical_port:0x%02x) has failed",
> +			ioc->name, le16_to_cpu(event_data->DevHandle),
> +			(unsigned long long)le64_to_cpu(event_data->SASAddress),
> +			event_data->PhysicalPort);
> +		break;
> +
> +	case MPI25_EVENT_SAS_DISC_ERR_SMP_TIMEOUT:

Please follow the style that is used elsewhere in the Linux kernel and do
not leave blank lines after "switch (...) {" nor after "break".

Thanks,

Bart.