Re: [PATCH v5 4/7] scsi_io_completion_action helper added

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-03-29 at 01:46 -0400, Douglas Gilbert wrote:
> +		/*
> +		 * Unprep the request and put it back at the head of the
> +		 * queue. A new command will be prepared and issued.
> +		 * This block is the same as case ACTION_REPREP in
> +		 * scsi_io_completion_action() above.
>  		 */
>  		if (q->mq_ops) {
>  			scsi_mq_requeue_cmd(cmd);
> @@ -1061,16 +1090,8 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
>  			scsi_release_buffers(cmd);
>  			scsi_requeue_command(q, cmd);
>  		}

Although I'm not happy about this code duplication:

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>








[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux