On Wed, 2018-03-28 at 12:15 +0200, bigeasy@xxxxxxxxxxxxx wrote: > On 2018-03-26 11:13:59 [-0400], Steven Rostedt wrote: > > > diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c > > > index 9c7bc1ca341a..3d35dad1de2c 100644 > > > --- a/drivers/target/target_core_tmr.c > > > +++ b/drivers/target/target_core_tmr.c > > > > Can you add a comment above the functions though? > > > > /* Expects to have se_cmd->se_sess->sess_cmd_lock held */ > > I could. I haven't heard from Bart / Nicholas about their opinion. I > know, we do this other places but Bart was against this kind of > annotation in 2/2 of this thread. > So I am waiting to hear from them :) The names of the two functions touched by patch 1/2 start with a double underscore. That by itself is already a hint that these should be called with a lock held (I know that this is not a universal convention in the Linux kernel). I'm fine either way - either with patch 1/2 as posted or patch 1/2 with the above comment added. Bart.
