On Sun, 2018-03-18 at 21:59 +0100, Douglas Gilbert wrote: > Place scsi_io_completion()'s complex error processing associated with a > local enumeration into a static helper function. That enumeration's > values start with "ACTION_" so use the suffix "_action" in the helper > function's name. Please split this patch into two patches: one that introduces the new function scsi_io_completion_action() without changing the logic of the code and a second patch that introduces the "sense_valid_and_current" variable. I think that that will make the changes easier to read and to verify. Thanks, Bart.