On Fri, 2018-03-23 at 18:19 +0100, bigeasy@xxxxxxxxxxxxx wrote: > __target_attach_tg_pt_gp() and __target_detach_tg_pt_gp() check if the caller > holds lun_tg_pt_gp_lock(). Both functions are static, the callers are > acquiring the lock before the invocation of the function so the check > looks superfluous. > Remove it. Does this check cause trouble to anyone or to a specific kernel configuration? In other words, do we really need to remove these checks? I think that these checks are useful as documentation to people who read the SCSI target code. The target code is already hard to follow so I think any documentation, especially documentation in the form of code that is checked at runtime, is welcome. Thanks, Bart.
