Em Thu, Mar 22, 2018 at 06:37:45AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 21, 2018 at 11:43:58AM -0700, Linus Torvalds escreveu: > > [ Adding PeterZ to participants due to query about lockdep_assert() ] > > > > On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo > > <acme@xxxxxxxxxx> wrote: > > > > > > assert_spin_locked(&cmd->t_state_lock); > > > - WARN_ON_ONCE(!irqs_disabled()); > > > + WARN_ON_ONCE_NONRT(!irqs_disabled()); > > > > Ugh. > > > > Can't we just replace both of those with a lockdep annotation? > > Huh, even better, when that feature gets finished (tglx said it was > being developed, not there yet tho) it'll allow further reduction of the > PREEMPT_RT_FULL patchkit. We'd get rid of these: [acme@jouet patches-4.11.12-rt15]$ grep "^+[[:space:]]\+.*NONRT" *.patch dm-make-rt-aware.patch:+ BUG_ON_NONRT(!irqs_disabled()); fs-block-rt-support.patch:+ WARN_ON_NONRT(!irqs_disabled()); i915-bogus-warning-from-i915-when-running-on-PREEMPT.patch:+ WARN_ON_NONRT(!in_interrupt()); iommu-amd--Use-WARN_ON_NORT.patch:+ WARN_ON_NONRT(!irqs_disabled()); iommu-amd--Use-WARN_ON_NORT.patch:+ WARN_ON_NONRT(!irqs_disabled()); irqwork-push_most_work_into_softirq_context.patch:+ BUG_ON_NONRT(!irqs_disabled()); net-wireless-warn-nort.patch:+ WARN_ON_ONCE_NONRT(softirq_count() == 0); posix-timers-thread-posix-cpu-timers-on-rt.patch:+ WARN_ON_ONCE_NONRT(!irqs_disabled()); posix-timers-thread-posix-cpu-timers-on-rt.patch:+ WARN_ON_ONCE_NONRT(!irqs_disabled()); posix-timers-thread-posix-cpu-timers-on-rt.patch:+ WARN_ON_ONCE_NONRT(!irqs_disabled()); workqueue-use-locallock.patch:+ WARN_ON_ONCE_NONRT(!irqs_disabled()); [acme@jouet patches-4.11.12-rt15]$ - Arnaldo
