On Thu, 8 Mar 2018 11:52:25 -0800, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > On Thu, Mar 8, 2018 at 5:22 AM, Stephen Kitt <steve@xxxxxxx> wrote: > > -static const int num_critical_sections = sizeof(critical_sections) > > - / sizeof(*critical_sections); > > +#define NUM_CRITICAL_SECTIONS 14 > > The compiler doesn't treat "const" as a literal, hence the need to > change this. However, you can still use the sizeof (actually, this is > exactly ARRAY_SIZE()). Perhaps: > > #define NUM_CRITICAL_SECTIONS ARRAY_SIZE(critical_sections) > > ? > > Otherwise, looks great! Thanks, v2 incoming... Regards, Stephen
Attachment:
pgp6rZWndw1x9.pgp
Description: OpenPGP digital signature
