RE: [PATCH 3/3] qla2x00: fix init error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hi Meelis,
> 
> This issue should already be addressed by a very recent commit:
> 
> 6a2cf8d3663e13e1 scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

Good, will test.

> Furthermore, the additions in qla2x00_remove_one of:
> 
> +	qla2x00_mem_free(ha);
> +
> +	qla2x00_free_queues(ha);
> +
> 
> are unnecessary. These routines are already called by qla2x00_free_device just above
> in qla2x00_remove_one.

No, that was the point of my changes - they must not be called from 
qla2x00_free_device or they will be double freed in some cases.


-- 
Meelis Roos (mroos@xxxxxxxx)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux