On Mon, Mar 05 2018 at 2:23am -0500, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx> wrote: > > -----Original Message----- > > From: Laurence Oberman [mailto:loberman@xxxxxxxxxx] > > Sent: Saturday, March 3, 2018 3:23 AM > > To: Don Brace; Ming Lei > > Cc: Jens Axboe; linux-block@xxxxxxxxxxxxxxx; Christoph Hellwig; Mike > > Snitzer; > > linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke; Arun Easi; Omar Sandoval; > > Martin K . Petersen; James Bottomley; Christoph Hellwig; Kashyap Desai; > > Peter > > Rivera; Meelis Roos > > Subject: Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue > > ... > > Unless Kashyap is not happy we need to consider getting this in to Linus > > now > > because we are seeing HPE servers that keep hanging now with the original > > commit now upstream. > > > > Kashyap, are you good with the v3 patchset or still concerned with > > performance. I was getting pretty good IOPS/sec to individual SSD drives > > set > > up as jbod devices on the megaraid_sas. > > Laurence - > Did you find difference with/without the patch ? What was IOPs number with > and without patch. > It is not urgent feature, so I would like to take some time to get BRCM's > performance team involved and do full analysis of performance run and find > pros/cons. Performance doesn't matter if the system cannot even boot (e.g. HPE servers with hpsa using the latest linus tree). Have you tried your testbed with just applying the first 2 patches? Or do those cause the performance hit and the follow-on patches in the series attempt to recover from it? Mike