On Mon, 5 Mar 2018, Michael Schmitz wrote: > All Zorro-3 boards have to have both their regs and dma_regs remapped. > I see. > What's confusing is that there is only a single Zorro-3 board currently > supported by the driver. Others will be added and I"ll use a switch > statement to pick the appropriate address based on the ID. That might > make it clearer. > Maybe you should add a comment to explain that. > > Maybe store ent->id in the private struct to get around that? > > Yes, that could be done. I still think it's not needed. > I see what you mean. Given your explanation above, you could simply remove the confusing if (ent->id == ZORRO_PROD_PHASE5_BLIZZARD_1230_IV_1260) conditional. That's because the (ioaddr > 0xffffff) test already takes care of the zorro2/zorro3 distinction, right? That would avoid the confusing ioremap/iounmap asymmetry. -- > Cheers, > > Michael >
