Re: [PATCH 4/6] libata: Fix ata_err_string()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/01/2018 08:40 PM, Damien Le Moal wrote:
> Add proper error string output for ATA_ERR_NCQ and ATA_ERR_NODEV_HINT
> instead of returning "unknown error".
> 
> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx>
> ---
>  drivers/ata/libata-eh.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index d6264235c3d7..006ea1507dcf 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1482,6 +1482,10 @@ static const char *ata_err_string(unsigned int err_mask)
>  		return "invalid argument";
>  	if (err_mask & AC_ERR_DEV)
>  		return "device error";
> +	if (err_mask & AC_ERR_NCQ)
> +		return "NCQ error";
> +	if (err_mask & AC_ERR_NODEV_HINT)
> +		return "Polling detection error";
>  	return "unknown error";
>  }
>  
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux