On Mon, 2018-02-26 at 13:48 -0500, Douglas Gilbert wrote: > Note: checkpatch.pl suggests that the BUG and BUG_ON macros be replaced > by WARN and WARN_ON . Perhaps others could comment on this. Yes BUG() and BUG_ON() are usually a bad idea. Linus was even very eloquent about this in the SCSI Midlayer: https://www.spinics.net/lists/linux-scsi/m sg105428.html So please don't use it. -- Johannes Thumshirn Storage jthumshi rn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850