Re: [PATCH] scsi_io_completion cleanup and fix CONDITION MET handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-02-26 at 13:48 -0500, Douglas Gilbert wrote:
> Note: checkpatch.pl suggests that the BUG and BUG_ON macros be replaced
> by WARN and WARN_ON . Perhaps others could comment on this.

Yes BUG() and BUG_ON() are usually a bad idea. Linus was even very eloquent
about this in the SCSI Midlayer: https://www.spinics.net/lists/linux-scsi/m
sg105428.html

So please don't use it.

-- 
Johannes Thumshirn                                          Storage
jthumshi
rn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH,
Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham
Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600
D0D0 0393 969D 2D76 0850



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux