Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "jejb@xxxxxxxxxxxxxxxxxx" <jejb@xxxxxxxxxxxxxxxxxx>, "martin.petersen@xxxxxxxxxx" <martin.petersen@xxxxxxxxxx>, "jianchao.w.wang@xxxxxxxxxx" <jianchao.w.wang@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
From: Bart Van Assche <Bart.VanAssche@xxxxxxx>
Date: Tue, 27 Feb 2018 05:12:36 +0000
Accept-language: en-US
Cc: "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "hch@xxxxxx" <hch@xxxxxx>
In-reply-to: <db9c47e6-d8ea-1e9e-609a-ff1b1db3769c@oracle.com>
Wdcipoutbound: EOP-TRUE

On Tue, 2018-02-27 at 12:00 +0800, jianchao.wang wrote:
> On the other hand, this patch is to align the actions between blk-mq and block
> legacy code in __scsi_queue_insert.

Hello Jianchao,

Since the legacy SCSI core unpreps an reprepares a request when requeuing it I
think your patch does not align the blk-mq and legacy block layer actions but
instead makes the behavior of the two code paths different.

Thanks,

Bart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
  - From: jianchao.wang

References:
- [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
  - From: Jianchao Wang
- Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
  - From: Bart Van Assche
- Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
  - From: jianchao.wang
- Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
  - From: Bart Van Assche
- Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
  - From: jianchao.wang

Prev by Date: RE: [PATCH] megaraid_sas: Re-enable WRITE SAME
Next by Date: Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
Previous by thread: Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
Next by thread: Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]