On Wed, 2018-02-14 at 16:29 +0000, John Garry wrote: > On 13/02/2018 17:49, Bart Van Assche wrote: > > On 02/13/18 02:17, John Garry wrote: > > > On 12/02/2018 18:45, Bart Van Assche wrote: > > > > -/** > > > > +/* > > > > * sas_configure_parent -- configure routing table of parent > > > > - * parent: parent expander > > > > - * child: child expander > > > > - * sas_addr: SAS port identifier of device directly attached to child > > > > + * @parent: parent expander > > > > + * @child: child expander > > > > + * @sas_addr: SAS port identifier of device directly attached to child > > > > > > and no mention of @include here > > > > Also for the 'include' argument, a suggestion of how to document it > > would be welcome. > > To be honest, I am not so fimilar with this specific part of the code. > > As I see, the @include argument is to flag whether we want to setup or > tear down a routing for parent (upstream) expander device. Thanks for the feedback. I will have a look at the SAS spec to see what the meaning of this parameter is. Bart.
