Martin, On 2/22/18 13:06, Martin K. Petersen wrote: > > Bart, > >> This patch depends on another patch that is not yet in Martin's >> tree. > > Nobody reviewed it. Same goes for your queuecommand tweak :/ > > I'm pretty picky about getting at least one other person than me to look > over core changes. > > Reviewers: Fame and fortune awaits! It looks OK to me, at least if CONFIG_DEBUG_OBJECTS_RCU_HEAD is turned off since the init_rcu_head() and destroy_rcu_head() functions only care about that. With rcu head debug turned on, I am not so sure. The object debug code will have references to unused rcu heads left behind for unused scsi cmds, which are indeed dynamically allocated for a device together with requests when the device is initialized, but they are never freed until the device is removed. So "dynamically allocated object", yes, but that does not match the use of the object done in scsi (i.e. alloc before use + free after use). Because of this doubt, No reviewed-by from me. I will miss fame and fortune this time :) Best regards. -- Damien Le Moal, Western Digital
