Martin, Applied to 4.17/scsi-queue. Minor patch submission nits below (for next time, I fixed them up). > Error injection in scsi_debug (e.g. opts=16, SDEBUG_OPT_TRANSPORT_ERR) > currently doesn't work correctly because the test for sqcp in > resp_read_dt0() and similar resp_*() functions always fails. sqcp is > set from cmnd->host_scribble, which is set in schedule_resp(), which > is called from scsi_debug_queuecommand() after calling the resp_* > function. > > Defer calling resp_*() until after cmnd->host_scribble is > set in schedule_resp(). > > Fixes: c483739430f1 "scsi_debug: add multiple queue support" Your Signed-off-by: needs to go here. And then you need a "---" separator before the change log. > Changes in v2: Adapted to code changes after 80c49563e250 > "scsi: scsi_debug: implement IMMED bit" > > Notes about this adaptation: > > The "flags &= ~F_LONG_DELAY" statement in scsi_debug_queuecommand() > from 80c49563e250 had no effect. Dropped it. > Because we call the resp_*() function later now, the code flow in > schedule_resp() is slightly different now for the IMMED case - instead of > falling through to the "respond_in_thread" label immediately, the command will > be put in the work queue with zero delay. > > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx> Thanks! -- Martin K. Petersen Oracle Linux Engineering
