On 02/12/2018 07:57 PM, Bart Van Assche wrote:
> Make scsi_test_unit_ready() send at most as many TURs as specified
> in the 'retries' argument instead of retries * (retries + 1) / 2.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index b03cb2d5b733..9c793090dbf1 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -2607,7 +2607,7 @@ scsi_test_unit_ready(struct scsi_device *sdev, int timeout, int retries,
> /* try to eat the UNIT_ATTENTION if there are enough retries */
> do {
> result = scsi_execute_req(sdev, cmd, DMA_NONE, NULL, 0, sshdr,
> - timeout, retries, NULL);
> + timeout, 1, NULL);
> if (sdev->removable && scsi_sense_valid(sshdr) &&
> sshdr->sense_key == UNIT_ATTENTION)
> sdev->changed = 1;
>
At one point we _really_ need to clean up BLOCK_PC command handling.
This 'some parts are handled by the core, some parts need to be
evaluated by the caller' magic is driving my nuts :-(
Anyway.
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
