On Wed, Feb 07, 2018 at 07:38:39AM -0800, James Smart wrote: > On 2/7/2018 1:58 AM, Johannes Thumshirn wrote: > > On Tue, Feb 06, 2018 at 06:28:44PM -0800, James Smart wrote: > > > lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > > > - "0469 lpfc_link_speed attribute cannot be set to %d, " > > > - "allowed values are ["LPFC_LINK_SPEED_STRING"]\n", val); > > > + "0469 lpfc_link_speed attribute cannot be set to %d, " > > > + "allowed values are ["LPFC_LINK_SPEED_STRING"]\n", val); > > > > lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > > "0469 lpfc_link_speed attribute cannot be set to %d, " > > "allowed values are [%s]\n", > > val, LPFC_LINK_SPEED_STRING); > > > > And possible have the whole quoted string on one line for easier grepping. > > checkplatch.pl should've told you that. > > > > Checkpatch didn't say anything interesting. We consistently have line > spanning as the lines are fairly verbose. Not an easy way to avoid that. > > Regardless, no big deal. The line-breaks make it non-trivial to grep for an error message. No big deal and with lpfc having the numeric prefixes for prints this is actually not needed. What I mainly didn't like was the implicit pasting of the define instead of %s. But no big deal as well. -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
