On 01/24/2018 11:45 PM, James Smart wrote:
> Currently, write underruns (mismatch of amount transferred vs scsi
> status and its residual) detected by the adapter are not being
> flagged as an error. Its expected the target controls the data
> transfer and would appropriately set the RSP values. Only read
> underruns are treated as errors.
>
> Revise the SCSI error handling to treat write underruns as an
> error as well.
>
> Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>
> ---
> drivers/scsi/lpfc/lpfc_scsi.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index dcc86936e6fc..10c2dc0cf1fa 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -3772,20 +3772,18 @@ lpfc_handle_fcp_err(struct lpfc_vport *vport, struct lpfc_scsi_buf *lpfc_cmd,
> scsi_set_resid(cmnd, be32_to_cpu(fcprsp->rspResId));
>
> lpfc_printf_vlog(vport, KERN_INFO, LOG_FCP_UNDER,
> - "9025 FCP Read Underrun, expected %d, "
> + "9025 FCP Underrun, expected %d, "
> "residual %d Data: x%x x%x x%x\n",
> fcpDl,
> scsi_get_resid(cmnd), fcpi_parm, cmnd->cmnd[0],
> cmnd->underflow);
>
> /*
> - * If there is an under run check if under run reported by
> + * If there is an under run, check if under run reported by
> * storage array is same as the under run reported by HBA.
> * If this is not same, there is a dropped frame.
> */
> - if ((cmnd->sc_data_direction == DMA_FROM_DEVICE) &&
> - fcpi_parm &&
> - (scsi_get_resid(cmnd) != fcpi_parm)) {
> + if (fcpi_parm && (scsi_get_resid(cmnd) != fcpi_parm)) {
> lpfc_printf_vlog(vport, KERN_WARNING,
> LOG_FCP | LOG_FCP_ERROR,
> "9026 FCP Read Check Error "
>
I so hope you have this tested ...
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
